Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add List Layouts #4

Merged
merged 36 commits into from
Oct 23, 2023
Merged

Add List Layouts #4

merged 36 commits into from
Oct 23, 2023

Conversation

Gold872
Copy link
Owner

@Gold872 Gold872 commented Oct 23, 2023

No description provided.

Gold872 added 30 commits August 26, 2023 17:11
@Gold872
Added draggable list layout widget
ec47cfe
@Gold872
Added basic layout dragging in
5fbd7e9
@Gold872
Added json saving and loading
52d4d46
@Gold872
Removed random print statement
3e63bde
@Gold872
Added a condition to accept a widget and created foundation for expor…
d4b82aa 
…ting list
@Gold872
Adjusted parameters for drag end
f94ffac
@Gold872
Merge branch 'main' of https://github.com/Gold872/elastic-dashboard i…
c35ddd6 
…nto list-layout
@Gold872
Merge branch 'main' of https://github.com/Gold872/elastic-dashboard i…
515c89f 
…nto list-layout
@Gold872
Merge branch 'main' of https://github.com/Gold872/elastic-dashboard i…
5024b4c 
…nto list-layout
@Gold872
Remove double refresh method call
b8931f2
@Gold872
Merge branch 'main' of https://github.com/Gold872/elastic-dashboard i…
2270815 
…nto list-layout
@Gold872
Added preview when hovering over layout
251253a
@Gold872
Merge branch 'main' of https://github.com/Gold872/elastic-dashboard i…
603a7aa 
…nto list-layout
@Gold872
Added dragging into list layouts
466ed44
@Gold872
Merge branch 'main' of https://github.com/Gold872/elastic-dashboard i…
7b6259f 
…nto list-layout
@Gold872
Merge branch 'main' of https://github.com/Gold872/elastic-dashboard i…
d595525 
…nto list-layout
@Gold872
Display 'List Layout' instead of 'List View' on add widget dialog
56e883b
@Gold872
Added list layout loading
0cdb85a
@Gold872
Decreased resizing handle size
4406888
@Gold872
Added reordering and edit properties for list layouts
77c80e4
@Gold872
Allow dragging widgets out of list layout
e3f9cc4
@Gold872
Unsubscribe and dispose when removing list layouts
e6b982a
@Gold872
Fixed widget sizing when creating nt4 widget
8606acb
@Gold872
Fixed dragging widget getting stuck
b5422dd
@Gold872
Merge branch 'main' of https://github.com/Gold872/elastic-dashboard i…
fe8df07 
…nto list-layout
@Gold872
Adjusted parameters for will accept widget
efa8664
@Gold872
Update drag location of widgets being dragged in
c5e0f9a
@Gold872
Merge branch 'main' of https://github.com/Gold872/elastic-dashboard i…
ebc3b9f 
…nto list-layout
@Gold872
Merge branch 'main' of https://github.com/Gold872/elastic-dashboard i…
8a75c4a 
…nto list-layout
@Gold872
Major code refactor & cleanup
9b98fed 
* Widgets don't get copied to a separate list when dragging
* WidgetContainerModel doesn't have unnecessary fields
* Logic for weather a widget container is being dragged to a valid location/layout is handled by DashboardGrid
* DashboardGrid instance is passed into each container instead of having tons of boolean callback methods
* JsonData map is no longer a field in DashboardGrid and DraggableWidgetContainer, it's only passed in the fromJson constructor
* The cursor's global position is used to determine layout locations
* Numerous methods no longer have unneeded parameters
@codecov-commenter
Copy link

Codecov Report

Attention: 491 lines in your changes are missing coverage. Please review.

Comparison is base (bb296ef) 51.36% compared to head (dfa4b6d) 54.78%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   51.36%   54.78%   +3.41%     
==========================================
  Files          51       54       +3     
  Lines        4575     5111     +536     
==========================================
+ Hits         2350     2800     +450     
- Misses       2225     2311      +86
Files Coverage Δ
lib/services/nt4_connection.dart 27.86% <100.00%> (ø)
lib/widgets/network_tree/network_table_tree.dart 97.70% <100.00%> (+0.20%) ⬆️
...aggable_containers/draggable_layout_container.dart 75.00% <75.00%> (ø)
...ble_containers/draggable_nt4_widget_container.dart 75.29% <71.11%> (+2.45%) ⬆️
lib/pages/dashboard_page.dart 61.50% <66.66%> (-0.40%) ⬇️
lib/widgets/dialog_widgets/layout_drag_tile.dart 4.00% <4.00%> (ø)
...aggable_containers/draggable_widget_container.dart 59.03% <34.78%> (-9.57%) ⬇️
lib/services/shuffleboard_nt_listener.dart 48.30% <39.15%> (-33.01%) ⬇️
...ts/draggable_containers/draggable_list_layout.dart 34.26% <34.26%> (ø)
lib/widgets/dashboard_grid.dart 49.76% <49.37%> (+7.88%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872 Gold872 merged commit eaa30ac into main Oct 23, 2023
5 checks passed
@Gold872 Gold872 deleted the list-layout branch October 23, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gold872 @codecov-commenter